Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Block editor: save when editor is backgrounded or un-presented #1044

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Block editor: save when editor is backgrounded or un-presented #1044

merged 2 commits into from
Dec 21, 2023

Conversation

gordonbrander
Copy link
Collaborator

Fixes #1041

Testing

Setup:

  • Go to Settings > Developer > Block Editor, and turn on block editor.

Scenario 1:

  • Create a new note or edit an existing note
  • Type some text
  • Swipe back

What should happen: note should be saved.

Scenario 2:

  • Create a new note or edit an existing note
  • Type some text
  • Background the app

What should happen: note should be saved.

@gordonbrander
Replay succeed save on app store
d7f4d4b 
This causes list to be refreshed.
bfollington
bfollington approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@bfollington bfollington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works in testing too :)

@bfollington bfollington merged commit 428478e into main Dec 21, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bfollington bfollington bfollington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block editor should save when exiting editor
2 participants
@gordonbrander @bfollington