This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
AI Reward Cards #1129
Merged
AI Reward Cards #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
force-pushed
the
2024-03-06-reward-cards
branch
from
53b2ada
to
1a9beb2
Compare
bfollington
commented
Mar 20, 2024
| @@ -254,6 +255,7 @@ struct DeckDetailStackCursor: CursorProtocol { | |||
| // MARK: Model | |||
| struct DeckModel: ModelProtocol { | |||
| public static let backlinksToDraw = 1 | |||
| public static let maxRewardCardBufferSize = 4 | |||
There was a problem hiding this comment.
3, 4 and 5 all feel good in different ways
gordonbrander
approved these changes
Mar 20, 2024
| import Foundation | ||
| import KeychainSwift | ||
|
|
||
| actor KeychainService { |
| public let instruction: String | ||
| } | ||
|
|
||
| actor OpenAIService { |
There was a problem hiding this comment.
A followup I'd like us to do:
- I'd like to think about how to "protocolize" this API surface to avoid getting two entangled with the specifics of one model.
- The chat API is a natural fit here. Most of the API vendors have converged on something nearly exactly the same shape as OpenAI's chat API.
- The service should probably talk back and forth in a
CodableAIChattype that can be serialized/deserialized to JSON. Similar shape to the chat API request/response, with an array of messages withsystem,assistant, anduserroles, but free of model specifics.
There was a problem hiding this comment.
One more consideration. Let's think about how this might route through our PromptService. In principle, I like the idea of routing everything through it as a dispatcher.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a dependency on a keychain interfacing library, I was tempted to avoid it but the direct interface to keychain immediately made me understand why everyone is using a library.
AI features can be enabled from the Developer Settings menu:
Screen.Recording.2024-03-19.at.3.58.54.pm.mov