This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Configurable sort order for notebook #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
commented
Apr 3, 2024
| ForEach(entries.indices, id: \.self) { idx in | ||
| let entry = entries[idx] | ||
|
|
||
| ForEach(entries, id: \.self) { entry in |
There was a problem hiding this comment.
We didn't need the index anymore, apparently
There was a problem hiding this comment.
Entries should be Identifiable, so we shouldn't need the second argument at all. That would be preferable, since \.self will consider value equality, and we would prefer to compare ID equality.
bfollington
commented
Apr 3, 2024
| @@ -134,6 +132,7 @@ struct EntryListView: View { | |||
| ) | |||
| } | |||
| } | |||
| .id(entry.address) | |||
There was a problem hiding this comment.
This fixes the animations
gordonbrander
approved these changes
Apr 8, 2024
| @@ -22,6 +22,7 @@ struct CountChip: View, Equatable { | |||
|
|
|||
| var body: some View { | |||
| Text(Self.asText(count: count)) | |||
| .contentTransition(.numericText()) | |||
| ForEach(entries.indices, id: \.self) { idx in | ||
| let entry = entries[idx] | ||
|
|
||
| ForEach(entries, id: \.self) { entry in |
There was a problem hiding this comment.
Entries should be Identifiable, so we shouldn't need the second argument at all. That would be preferable, since \.self will consider value equality, and we would prefer to compare ID equality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort / filter the notebook view. I added a few new options that occurred to me as easy and useful.
Screen.Recording.2024-04-04.at.10.59.24.AM.mov