This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Remove testWritesThenCloseThenReopenWithVars
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
changed the title
testWritesThenCloseThenReopenWithVars
justinabrahms
approved these changes
Sep 13, 2023
gordonbrander
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing while testing subconsciousnetwork/noosphere#623, leading us to question why it ever passed in the first place. Due to Swift compiler trivia the deinit for
Noosphereis not guaranteed to be called at the time we overwrite the variable, meaning two instances ofNoosphereco-exist pointing at the same data. We should not ever be trying to open multiple instances ofNoospherepointing at the same database.After team discussion we decided to drop this test case and make this an explicit failure case on the Noosphere side.