This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Block Editor: use SwiftUI for transcludes and related #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonbrander
commented
Nov 11, 2023
gordonbrander
commented
Nov 13, 2023
gordonbrander
commented
Nov 13, 2023
gordonbrander
commented
Nov 13, 2023
gordonbrander
commented
Nov 13, 2023
xcode/Subconscious/Shared/UIKit/BlockEditor/BlockEditorViewController.swift
Show resolved
Hide resolved
gordonbrander
commented
Nov 13, 2023
xcode/Subconscious/Shared/UIKit/BlockEditor/Blocks/Appendix/Related/RelatedCell.swift
Show resolved
Hide resolved
gordonbrander
commented
Nov 13, 2023
xcode/Subconscious/Shared/UIKit/BlockEditor/Blocks/Appendix/Related/RelatedCell.swift
Show resolved
Hide resolved
Not needed.
gordonbrander
commented
Nov 13, 2023
No longer needed.
gordonbrander
commented
Nov 13, 2023
bfollington
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
Replaces UIKit transcludes with SwiftUI transcludes using UIHostingView from #981.
The transclude callbacks are not yet hooked up to anything. Saving this for a future PR where we integrate the block editor with real data and services.
Progress toward #214.