Skip to content

Conversation

@vwheeler63
Copy link

@vwheeler63 vwheeler63 commented Dec 24, 2025

appear to have been erroneously deleted in commit dfac893. Either that, or the ChannelRepositoryTools: Test Default Channel command needs to stop requiring the tests/test.py file be present in order to run the tests (line 142 of ChannelRepositoryTools/tests.py), which has not been changed for 11 years, so I have to assume it was the recent deletion of the tests/ folder in this repository in commit dfac893 which was at fault.

Simultaneously this deletion prevented new submitted packages from running ChannelRepositoryTools: Test Default Channel before submitting new Sublime Text packages.

Fixes #9272

cc: @wbond

This is a bug fix, not a new-package submission, so the below are not applicable for this particular PR.

  • [n/a] I'm the package's author and/or maintainer.
  • I have have read the docs.
  • [n/a] I have tagged a release with a semver version number.
    This is a bug fix, not a new-package submission.
  • [n/a] My package repo has a description and a README describing what it's for and how to use it.
  • [n/a] My package doesn't add context menu entries. *
  • [n/a] My package doesn't add key bindings. **
  • [n/a] Any commands are available via the command palette.
  • [n/a] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • [n/a] If my package is a syntax it doesn't also add a color scheme. ***
  • [n/a] I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

appear to have been erroneously deleted in commit dfac893.

Simultaneously this deletion prevented new submitted packages from
running `ChannelRepositoryTools: Test Default Channel` before
submitting new Sublime Textx packages.

Fixes sublimehq#9272
@deathaxe
Copy link
Contributor

deathaxe commented Dec 25, 2025

Test infrastructure moved to https://github.com/packagecontrol/st-schema-reviewer-action github actions by intend.

see also

Test implementation was decoupled as probably being useful for any (external or 3rd-party) repository, ignoring some of the performed checks are maybe useful only for this default channel.

@vwheeler63
Copy link
Author

vwheeler63 commented Dec 25, 2025

Thank you, @deathaxe ! I was missing history on why the tests/ folder was removed, and so the part of the conflict that needs to be resolved is in ChannelRepositoryTools instead of package_control_channel.

@vwheeler63 vwheeler63 closed this Dec 25, 2025
@vwheeler63 vwheeler63 deleted the fix/fix_issue_9272_blocking_testing_new_pkgs branch December 25, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Blocking Submitting New Packages to this Repository

2 participants