Skip to content

Conversation

hola-soy-milk
Copy link

@hola-soy-milk hola-soy-milk commented Sep 13, 2022

I noticed that subo create runnable no longer works. @cohix am I correct in assuming it should be subo create module now?

@hola-soy-milk hola-soy-milk requested a review from cohix September 13, 2022 13:44
@flaki flaki force-pushed the ramon/update-smoketest branch from 3b3f92b to 260c33a Compare September 21, 2022 12:43
@flaki
Copy link
Contributor

flaki commented Sep 21, 2022

So I rebased this upon #360 but somoketests will still fail, simply because we have updated the module (née "runnable") detection code from .runnable.yaml-s to .module.yaml-s, which change needs to go into subo first, then we need to update the builder Docker images because they bundle subo -- and you guessed it, the smoketest uses the Docker toolchain.

@flaki flaki requested review from jessicarose and ospencer and removed request for jessicarose September 21, 2022 17:29
@flaki
Copy link
Contributor

flaki commented Sep 21, 2022

This last commit adds make subo/toolchaintest via ./scripts/toolchaintest.sh that is largely the same as the smoketest except it builds its own local dev images and uses them. I yoinked out these image builds from builder.mk, though they are largely the same as the builds in there so in the future we could refactor this and get rid of the duplication but for now this means that make subo/toolchaintest will build new images and test project & module creation; currently this test should be passing (it does on my machine).

@flaki
Copy link
Contributor

flaki commented Sep 21, 2022

(Please note: the tests should succeed but cleanup might fail due to root-owned build artifacts as per #342; but this is a sort of chicken & egg problem as I need the image builds and tests to work before I can get on finishing that change so this can be safely ignored for now)

@arbourd
Copy link
Contributor

arbourd commented Nov 22, 2022

Closing this as we recently implemented this (and split the templates). Thanks @hola-soy-milk!

@arbourd arbourd closed this Nov 22, 2022
@arbourd arbourd deleted the ramon/update-smoketest branch November 24, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants