Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate the Web3 Name SDK from Space.ID #604

Merged
merged 3 commits into from
Nov 29, 2023
Merged

feat: integrate the Web3 Name SDK from Space.ID #604

merged 3 commits into from
Nov 29, 2023

Conversation

mogithehurt
Copy link
Contributor

modified:   package.json
modified:   src/hooks/useEns.tsx
modified:   yarn.lock

Description

integrate the Web3 Name SDK from Space.ID in to the SubQuery Kepler app.
When users link their accounts, we should first check ENS, then check SpaceID for a linked account name
List any dependencies that are required for this change.
@web3-name-sdk/core

Ticket: subquery/developer-guild#54

Type of change

  • New feature (non-breaking change which adds functionality)

	modified:   package.json
	modified:   src/hooks/useEns.tsx
	modified:   yarn.lock
@HuberTRoy
Copy link
Member

Hi~, Thanks for your PR.

There have some problems:

  1. When fetch lots of ens names, the internal RPC endpoint is not enough for fetch all in once. Please make sure /delegator/indexers/top can fetch all names, e.g: add more RPC endpoints to do load balancing / reducing the concurrent count.
  2. Would better to create a new hook named useSpaceID or change the useEns. Please make sure the hook's name is all about their feature.

@mogithehurt
Copy link
Contributor Author

mogithehurt commented Nov 28, 2023

  1. When fetch lots of ens names, the internal RPC endpoint is not enough for fetch all in once. Please make sure /delegator/indexers/top can fetch all names, e.g: add more RPC endpoints to do load balancing / reducing the concurrent count.

tested for indexers/top it fetch all names

  1. Would better to create a new hook named useSpaceID or change the useEns. Please make sure the hook's name is all about their feature.

done

@HuberTRoy HuberTRoy merged commit 989bfb6 into subquery:main Nov 29, 2023
1 check passed
@HuberTRoy
Copy link
Member

Thanks for your contribute~.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants