Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20250115 #14

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Fix 20250115 #14

merged 10 commits into from
Feb 12, 2025

Conversation

yoozo
Copy link
Contributor

@yoozo yoozo commented Jan 15, 2025

No description provided.

@@ -35,6 +35,7 @@ services:
- ${SUB_COMMAND:-} # set SUB_COMMAND env variable to "test" to run tests
- -f=/app
- --db-schema=app
- --unsafe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be reverted

@@ -22,12 +22,13 @@
"license": "MIT",
"dependencies": {
"@subql/common": "latest",
"@subql/types-stellar": "latest"
"@subql/types-stellar": "latest",
"soroban-client": "^1.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soroban-client is deprecated. This should be under @stellar/stellar-sdk

"@subql/testing": "latest",
"@subql/types": "latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed, this is substrate types. The same applies to all starters

@yoozo yoozo requested a review from stwiname February 12, 2025 02:37
@stwiname stwiname merged commit b5bc414 into main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants