Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct type safety issues and typos in entities.ts #2672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Correct type safety issues and typos in entities.ts #2672

wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Feb 11, 2025

  • Fix typo in error message: 'Unandled' -> 'Unhandled' node kind
  • Rename parameter 'IndexArgFields' to 'indexArgFields' for consistent camelCase naming
  • Replace 'any' type with 'unknown' in function parameters for better type safety

stwiname
stwiname requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the PR template and update the relevant changelogs.

Your description also mentions types changes but there are none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stwiname stwiname stwiname requested changes

@marilene38 marilene38 marilene38 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crStiv @stwiname @marilene38