Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: config update #141

Merged
merged 14 commits into from
Oct 5, 2024
Merged

docs: config update #141

merged 14 commits into from
Oct 5, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Oct 4, 2024

Overview

Resolve the issue that caused the op-succinct-proposer to send more than MAX_CONCURRENT_PROOFS to the network.

Enable configuring an alternative environment when deploying contracts or spinning up the new proposer.

Details

  • Add lastUpdatedTime on the ProofRequest.
  • Modify the logic for checking that a requested proof timed out during witness generation. Instead of checking against the time at which a request was created (which is incorrect), we now check against the last time that the request was updated with the lastUpdatedTime.
    • Previously, this caused the proposer to spam proofs.
    • Ex. The proposer creates many SPAN proof requests. Due to the maxConcurrentProofRequests limit, only 10 proofs are sent to witness generation. These proofs take ~1 hour to fulfill. Now, the new proofs are requested. While they're in witness generation (and their ProverRequestId is set to nil), the proposer checks if the proofs have timed out (as it doesn't have a direct way of polling that a proof is in the witness generation status).
  • More informative logging.
  • To supply an alternative environment (e.g. .env.conduit) when deploying the contracts or running the op-succinct-proposer, just pass the ENV_FILE argument.

@ratankaliani ratankaliani merged commit 5084f3a into main Oct 5, 2024
6 checks passed
@ratankaliani ratankaliani deleted the ratan/config-updates branch October 5, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant