feat: optimize powers computation in permutation functions #2481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation uses
random_elements[1].powers()iterator that computes powers on-the-fly, which is inefficient in inner loops. There's a TODO comment explicitly requesting this optimization.Solution
Pre-compute beta powers (up to 16) and store in vector instead of using iterator. This avoids repeated computation in loops while maintaining same functionality.
Changes:
populate_local_permutation_row: Replacepowers()iterator with pre-computed vectoreval_permutation_constraints: Apply same optimizationPR Checklist