Skip to content

Conversation

@tamirhemo
Copy link
Contributor

This PR changes the functionality of the verifier's crate verify_sp1_proof and verify_sp1_reduce_proof to only verify the validity of the proof itself and does not require a check against specified public values. The checks containing public values can be used via verify_sp1_proof_with_public_values.

@github-actions
Copy link
Contributor

Test Old New Diff
rust_crypto_rsa_test_pkcs_verify_100 101801349 102458397 0.6454 %
bn_test_bn_test_fq_inverse_100 766356 766356 0.0000 %
curve25519_dalek_test_ed25519_verify 32350169 32351904 0.0054 %
k256_test_verify_rand_lte_100 24742601 24823224 0.3258 %
bls12_381_tests_test_bls_add_100 15763438 15763438 0.0000 %
bls12_381_tests_test_sqrt_fp_100 1083364 1137198 4.9692 %
bls12_381_tests_test_bls_double_100 9218745 9218745 0.0000 %
bn_test_bn_test_fq_sqrt_100 763356 763356 0.0000 %
curve25519_dalek_test_zero_mul 197103 197103 0.0000 %
curve25519_dalek_ng_test_zero_msm 216592 216592 0.0000 %
k256_test_recover_rand_lte_100 5613800 5612700 -0.0196 %
k256_test_schnorr_verify 7038549 7030278 -0.1175 %
bls12_381_tests_test_inverse_fp2_100 3073419 3073419 0.0000 %
p256_test_recover_high_hash_high_recid 3284429 3505243 6.7231 %
curve25519_dalek_test_zero_msm 213024 213024 0.0000 %
sha_test_sha2_v0_10_6_expected_digest_lte_100_times 1734171 1734758 0.0338 %
curve25519_dalek_test_decompressed_expected_value 15688660 15995131 1.9535 %
secp256k1_program_test_recover_rand_lte_100 6601045 6599934 -0.0168 %
sha_test_sha2_v0_9_9_expected_digest_lte_100_times 1489284 1491689 0.1615 %
keccack_test_expected_digest_lte_100 2036564 2037663 0.0540 %
k256_test_recover_high_hash_high_recid 2633633 2779771 5.5489 %
curve25519_dalek_ng_test_add_then_multiply 6397998 6557211 2.4885 %
sha_test_sha3_expected_digest_lte_100_times 1668712 1668661 -0.0031 %
curve25519_dalek_ng_test_zero_mul 197063 197063 0.0000 %
secp256k1_program_test_verify_rand_lte_100 46801056 46794320 -0.0144 %
k256_test_recover_pubkey_infinity 124534 124534 0.0000 %
bls12_381_tests_test_inverse_fp_100 1375050 1375050 0.0000 %
bn_test_bn_test_fr_inverse_100 798356 798356 0.0000 %
bn_test_bn_test_g1_add_100 846338 846338 0.0000 %
curve25519_dalek_test_add_then_multiply 6474929 5875594 -9.2562 %
secp256k1_program_test_verify_v0_30_0_rand_lte_100 46689777 46774031 0.1805 %
rustcrypto_bigint_test_bigint_mul_add_residue 2253569 2253569 0.0000 %
p256_test_recover_rand_lte_100 7259639 7257140 -0.0344 %
p256_test_verify_rand_lte_100 24873810 24814219 -0.2396 %
secp256k1_program_test_recover_v0_30_0_rand_lte_100 6643458 6646837 0.0509 %
curve25519_dalek_ng_test_decompressed_noncanonical 206954 206954 0.0000 %
bls12_381_tests_test_sqrt_fp2_100 1883052 1833521 -2.6304 %
bn_test_bn_test_g1_double_100 648027 648048 0.0032 %
curve25519_dalek_test_decompressed_noncanonical 9169 9169 0.0000 %
p256_test_recover_pubkey_infinity 143003 143003 0.0000 %
rustcrypto_bigint_test_bigint_mul_mod_special 2315020 2315020 0.0000 %
sha_test_sha2_v0_10_8_expected_digest_lte_100_times 1731112 1733531 0.1397 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants