Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sender's name outside text box #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dimi20cen
Copy link

@Dimi20cen Dimi20cen commented Aug 27, 2023

  • Remove the logic that places sender's name inside TextBox
  • Modify the add_text method in ChatBox to place sender's name label above the message bubble

@chimosky @sourabhaa

- Remove the logic that places sender's name inside TextBox
- Modify the add_text method in ChatBox to place sender's name label above the message bubble
@chimosky
Copy link
Member

chimosky commented Sep 3, 2023

Tested 1cf02cc, looks fine with me.

@quozl can you test?

@quozl
Copy link
Contributor

quozl commented Sep 19, 2023

Haven't had a moment to test. But reviewing the commit message and changes, I don't understand why the change is being made. Could that be better explained please?

@quozl
Copy link
Contributor

quozl commented Sep 19, 2023

https://help.sugarlabs.org/en/chat.html will also need changing?

@Dimi20cen
Copy link
Author

Could that be better explained please?

Sure, moving the sender's name outside of the text box could improve readability and user experience. By isolating the message content, users may find it easier to focus on the textmessage itself.

@quozl
Copy link
Contributor

quozl commented Sep 20, 2023

I note could and may. I don't see how it could improve readability and user experience, or why we would want children to focus on the text message to the exclusion of the identity of the sender. Nice ideas, but have you any proof?

@Dimi20cen
Copy link
Author

Thank you for bringing up these concerns. My rationale is as follow.

By separating the sender's name from the message box, the interface becomes more straightforward and easier for children to digest each component—namely who sent the message and what the message says. However, I appreciate the concern about the importance of the sender's identity. The change does not obscure or minimize who the sender is but as I previously mentioned aims to visually separate the sender's information to make the overall chat easier to follow.

Most chat platforms do seperate the name from the actual message and that the base for my idea. That said, sadly, I don't have a study to provide proof.

@quozl
Copy link
Contributor

quozl commented Sep 21, 2023

Can you show me what it looks like before and after? Any new separation consumes display space that would otherwise be used for conversation. The app was originally designed for 1200x900 pixel display.

@Dimi20cen
Copy link
Author

Yep that's the before
Screenshot from 2023-09-21 09-43-55

and that's the after
Screenshot from 2023-09-21 09-40-44

@quozl
Copy link
Contributor

quozl commented Sep 22, 2023

Thanks. Your proposal consumes valuable vertical space. The colour of the bubble already conveys identity through the Sugar user colour settings, which can be customised by the child. In large chat groups, with a whole class participating, the colour will be the primary means of identification, followed by the bold child nickname, also customisable. Since what the child sets their nickname to is another form of communication, it should be correctly highlighted by the colour. Okay?

@Dimi20cen
Copy link
Author

Sure, no worries, I kind of overlooked the function of colour as a means of identification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants