Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shortcut Details to Documentation #4439

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Aman1919
Copy link
Contributor

This PR updates the documentation to include detailed information about keyboard shortcuts .

Copy link

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

@Aman1919
Copy link
Contributor Author

@walterbender could you review this ?

@omsuneri
Copy link
Member

@Aman1919 Can you please add the shortcuts for macOS too as many here uses Mac well how it would be like @walterbender ??
for ex. ctrl + C / cmd +C we can have this for every shortcuts i guess it would be nice to have this

@walterbender
Copy link
Member

Mac version would be good.
There are a few of these I didn't remember and I am not sure work as expected. / and \ for instance. At least in Firefox.
And maybe we should repurpose space to insert a rest block. Not sure we need a key board short cut for the canvas size. But I suppose that is for a separate PR.

Copy link

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
turtle-singer.test.js

Copy link

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
turtle-singer.test.js

@Aman1919
Copy link
Contributor Author

Mac version would be good. There are a few of these I didn't remember and I am not sure work as expected. / and \ for instance. At least in Firefox. And maybe we should repurpose space to insert a rest block. Not sure we need a key board short cut for the canvas size. But I suppose that is for a separate PR.

Hi @walterbender,
I've added the Mac keys, but I’ve noticed some issues. For instance, Alt + H seems to break the website—it downloads multiple SVGs and causes the site to blink. I’ll raise an issue for this.

@walterbender
Copy link
Member

Alt-H is not for the faint of heart. It generates artwork for every block. I use it for updating the doc files. Maybe we should make a note of that.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@Aman1919
Copy link
Contributor Author

@walterbender Got it !! I have added a little description for alt +h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants