Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common abstractions #244

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Extract common abstractions #244

wants to merge 13 commits into from

Conversation

avdb13
Copy link

@avdb13 avdb13 commented Nov 8, 2024

No description provided.

@avdb13 avdb13 changed the title Extract common abstraction utilities Extract common abstractions Nov 8, 2024
@avdb13 avdb13 marked this pull request as ready for review November 8, 2024 23:46
@sugyan sugyan self-requested a review November 9, 2024 14:12
sugyan
sugyan requested changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!
I think this is a very nice implementation.
I have submitted a change request to your repository, including removing unnecessary dependencies. Please check that much.
avdb13#1

atrium-common/Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugyan sugyan sugyan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdb13 @sugyan