♿️Improve keyboard accessibility for the document tree #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
from
c49c1f7 to
f72df6c
Compare
|
Size Change: +687 B (+0.02%) Total Size: 4.11 MB
|
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
2 times, most recently
from
5f35f48 to
2914ea9
Compare
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
from
2480747 to
86d98f0
Compare
AntoLC
reviewed
Dec 3, 2025
| opacity: 1; | ||
| } | ||
| } | ||
| /* Retirer le focus visuel du root item quand le focus est sur les actions */ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /* Retirer le focus visuel du root item quand le focus est sur les actions */ | |
| /* Remove visual focus from the root item when focus is on the actions */ |
| display: flex; | ||
| } | ||
| } | ||
| /* Retirer le focus visuel du tree item quand le focus est sur les actions */ |
Collaborator
There was a problem hiding this comment.
Comments should be in english.
| onOpenChange={onOpenChange} | ||
| > | ||
| <Icon | ||
| <Box |
| document.addEventListener('keydown', toActions, true); | ||
| return () => document.removeEventListener('keydown', toActions, true); | ||
| // node is a dependency, as it's checked for focus state | ||
| }, [node]); |
Collaborator
There was a problem hiding this comment.
Suggested change
| }, [node]); | |
| }, [node?.isFocused]); |
Comment on lines
19
to
27
| if (e.key !== 'F2' || document.querySelector(SELECTORS.MODAL)) { | ||
| return; | ||
| } | ||
|
|
||
| // Only react if the node is currently focused | ||
| if (!node?.isFocused) { | ||
| return; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I am not fond of coupling with dom-selectors. If a modal is opened I suppose the node would not be focused anymore, so is it not enough that ?
Suggested change
| if (e.key !== 'F2' || document.querySelector(SELECTORS.MODAL)) { | |
| return; | |
| } | |
| // Only react if the node is currently focused | |
| if (!node?.isFocused) { | |
| return; | |
| } | |
| if (e.key !== 'F2' || !node?.isFocused) { | |
| return; | |
| } |
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
from
9504a1c to
fa7d602
Compare
adds f2 shortcut to open options menu in sub-documents Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
2 times, most recently
from
b177dfa to
7d22f33
Compare
…treeview struct Signed-off-by: Cyril <[email protected]>
improves screen reader support with contextual accessibility guidance Signed-off-by: Cyril <[email protected]>
…e treeview struct
Ovgodd
force-pushed
the
fix/a11y-doctree-options
branch
from
7d22f33 to
cf8e1d5
Compare
…de the treeview struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve keyboard accessibility for the document tree by implementing F2 navigation to access action buttons (three dots menu and add child button) for both root items and sub-pages.
issues : 1160
Enregistrement.de.l.ecran.2025-12-02.131853.mp4
Proposal
Keyboard Navigation
Changes
Accessibility