♿️(frontend) Accessibility clean #641
Open
+1,146
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By following the "Docs - Accessibility" documentation, a background color is applied to the left block.
…cessibility-clean
Merge branch 'main' of https://github.com/suitenumerique/docs into accessibility-clean
Definition of the language in the HTML code dynamically
AntoLC
reviewed
Feb 17, 2025
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| useEffect(() => { | ||
| document.documentElement.lang = i18n.language || 'fr'; |
There was a problem hiding this comment.
It should have its own useEffect.
Suggested change
| document.documentElement.lang = i18n.language || 'fr'; | |
| useEffect(() => { | |
| document.documentElement.lang = i18n.language || 'fr'; | |
| }, [i18n.language]); |
There was a problem hiding this comment.
OK, I'll make this modification.
…eftPanel.tsx Co-authored-by: Anthony LC <[email protected]>
Co-authored-by: Anthony LC <[email protected]>
Modifications made following the feedback.
…ue/docs into accessibility-clean
To highlight the focus on the buttons.
…ue/docs into accessibility-clean ?
- Decorative icons are no longer keyboard-focusable. - Home icons appear with an aria-label. - In the second navigation, hide the icons with aria-hidden="true". - Add a lang="en" attribute to the term 'English' and a lang="de" attribute to 'Deutsch'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following issue 632, code modification to address the reported problems.
#632
Proposal