🐛(backend) compute ancestor_links in get_abilities if needed #725
+90
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
force-pushed
the
fix/compute_ancestors_links
branch
from
12f33cd to
294b88b
Compare
sampaccoud
reviewed
Mar 21, 2025
lunika
force-pushed
the
fix/compute_ancestors_links
branch
from
294b88b to
557e6d5
Compare
lunika
force-pushed
the
fix/compute_ancestors_links
branch
from
557e6d5 to
cf486d0
Compare
qbey
approved these changes
Mar 24, 2025
The refactor made in the tree view caching the ancestors_links to not compute them again in the document.get_abilities method lead to a bug. If the get_abilities method is called without ancestors_links, then they are computed on all the ancestors but not from the highest readable ancestor for the current user. We have to compute them with this constraint.
lunika
force-pushed
the
fix/compute_ancestors_links
branch
from
cf486d0 to
ae97d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The refactor made in the tree view caching the ancestors_links to not compute them again in the document.get_abilities method lead to a bug. If the get_abilities method is called without ancestors_links, then they are computes on all the ancestors but not from the highest readable ancestor for the current user. We have to compute them with this constraints and to avoid to compute it again and again we save the result in a cache.
Proposal