Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿️(nix) Added shell declaration for nix users #751

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PedroManse
Copy link
Contributor

@PedroManse PedroManse commented Mar 17, 2025

Purpose

To enable nix users to easly download the project's dependencies.

Proposal

Added shell.nix file with shell necessities for running the project.

  • Added shell declaration
  • Added CHANGELOG entry
  • Added pull request id to CHANGELOG
  • Squased commits

Added `docker`, `docker-compose` and `gnumake` as dependencies for a dev
environment for nix users

While `docker` and `docker-compose` are not needed in shell.nix if the
user has docker enabled, if docker daemon is not enabled system-wide,
these programs will warn the user, insted of saying they are not
installed.
Copy link

@ecoppens-dinum ecoppens-dinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can use 2 white spaces instead of tabs in nix files, as is standard in nix files.

@PedroManse
Copy link
Contributor Author

Hi @ecoppens-dinum.

I've made these changes in a new commit. Do you want me to squash it?
I'm still not very sure of the criteria for using different commits here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants