✨(front) turn on camera when applying effects #334
Merged
+151
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanVss
force-pushed
the
fix/enable-cam-effects
branch
from
0694320 to
5e78ed5
Compare
NathanVss
force-pushed
the
fix/enable-cam-effects
branch
2 times, most recently
from
45b4f1b to
e51ad4d
Compare
lebaudantoine
approved these changes
Feb 4, 2025
Comment on lines
+3
to
+45
| const loader = cva({ | ||
| base: { | ||
| borderRadius: '50%', | ||
| position: 'relative', | ||
| animation: 'rotate 1s linear infinite', | ||
| '&:before, &:after': { | ||
| content: '""', | ||
| boxSizing: 'border-box', | ||
| position: 'absolute', | ||
| inset: '0', | ||
| borderRadius: '50%', | ||
| borderStyle: 'solid', | ||
| borderColor: 'white', | ||
| }, | ||
| _before: { | ||
| animation: 'prixClipFix 2s linear infinite', | ||
| }, | ||
| _after: { | ||
| borderColor: 'white', | ||
| animation: | ||
| 'prixClipFix 2s linear infinite, rotate 0.5s linear infinite reverse', | ||
| inset: 6, | ||
| }, | ||
| }, | ||
| variants: { | ||
| size: { | ||
| small: { | ||
| width: '24px', | ||
| height: '24px', | ||
| '&:before, &:after': { | ||
| borderWidth: '2px', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| defaultVariants: { | ||
| size: 'small', | ||
| }, | ||
| }) | ||
|
|
||
| export const Loader = () => { | ||
| return <div className={loader()}></div> | ||
| } |
There was a problem hiding this comment.
you could use the same approach of the checkbox.ts, using styled
There was a problem hiding this comment.
Yep, but I don't understand why we is cva and styled used here and there and not only one of those? Maybe I'm missing something ofc
NathanVss
force-pushed
the
fix/enable-cam-effects
branch
from
e51ad4d to
33080cf
Compare
This component will be used for various purpose.
useSyncAfterDelay allows to enable loading indicators only if the loading takes more than a specific time. It prevent blinking effect when the loading time is nearly instant.
We want to automatically turn on the camera if its off when enabling a new effect.
NathanVss
force-pushed
the
fix/enable-cam-effects
branch
from
33080cf to
d492b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable camera when applying effects
Enregistrement.de.l.ecran.2025-02-04.a.16.35.59.mov
Show loader if it takes times
useSyncAfterDelayallows to enable loading indicators only if the loading takes more than a specific time. It prevent blinking effect when the loading time is nearly instant.Loading effects:
Please see below
Mon.film.2.mp4