Remove template default type definition #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
bug
alexander-schranz
force-pushed
the
bugfix/default-type
branch
from
41fd8fb
to
84b83aa
Compare
alexander-schranz
force-pushed
the
bugfix/default-type
branch
3 times, most recently
from
c2bae7a
to
9f670bc
Compare
alexander-schranz
force-pushed
the
bugfix/default-type
branch
from
9f670bc
to
86051c2
Compare
niklasnatter
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Not really happy with the hack in the StructureValidatorCompilerPass, but i guess we have to live with that for the moment. Hopefully sulu/sulu#5381 will get released soon, so we can remove that 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove template default type definition.
The hack should be removed when sulu/sulu#5381 is merged.
Why?
The default type definition does not work with multiple article types.