Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null returned instead of object when getting task_details form metadata #74

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix null returned instead of object when getting task_details form metadata #74

merged 1 commit into from
Jul 10, 2024

Conversation

NeuralClone
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #73
Related issues/PRs --
License MIT

What's in this PR?

Fixes a critical PHP error when retrieving task_details form metadata while attempting to create a new task:

TypeError:
Sulu\Bundle\AdminBundle\Metadata\FormMetadata\FormMetadata::getSchema():
Return value must be of type Sulu\Bundle\AdminBundle\Metadata\SchemaMetadata\SchemaMetadata, null returned

@alexander-schranz alexander-schranz merged commit 66027c7 into sulu:2.1 Jul 10, 2024
7 checks passed
@alexander-schranz
Copy link
Member

@NeuralClone thank you. Tagged as 2.1.3

@NeuralClone
Copy link
Contributor Author

Fantastic! Thank you!

@NeuralClone NeuralClone deleted the bugfix/return-null-instead-of-schemametadata branch July 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return value must be of type Sulu\Bundle\AdminBundle\Metadata\SchemaMetadata\SchemaMetadata, null returned
2 participants
@NeuralClone @alexander-schranz