-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ContentResolver to ContentAggregator #272
Rename ContentResolver to ContentAggregator #272
Conversation
Pull Request Test Coverage Report for Build 11035775534Details
💛 - Coveralls |
4f38d8e
to
34c9af1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP CS changes
.php-cs-fixer.dist.php
Outdated
->setRules([ | ||
'@Symfony' => true, | ||
'@Symfony:risky' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep this
.php-cs-fixer.dist.php
Outdated
'class_definition' => false, | ||
'concat_space' => ['spacing' => 'one'], | ||
'declare_strict_types' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep this
.php-cs-fixer.dist.php
Outdated
'no_useless_else' => true, | ||
'no_useless_return' => true, | ||
'php_unit_strict' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep this
.php-cs-fixer.dist.php
Outdated
'phpdoc_align' => ['align' => 'left'], | ||
'phpdoc_order' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep this
.php-cs-fixer.dist.php
Outdated
'strict_comparison' => true, | ||
'strict_param' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep this
d8116c8
to
eaebae2
Compare
4727521
to
828932a
Compare
depends on #273 for linting issues