Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ContentResolver to ContentAggregator #272

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Sep 25, 2024

depends on #273 for linting issues

@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11035775534

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11035600231: 0.0%
Covered Lines: 2530
Relevant Lines: 2530

💛 - Coveralls

@Prokyonn Prokyonn marked this pull request as ready for review September 25, 2024 09:30
@Prokyonn Prokyonn changed the title Draft: Rename ContentResolver to ContentAggregator Rename ContentResolver to ContentAggregator Sep 25, 2024
@Prokyonn Prokyonn force-pushed the enhancement/rename-content-resolver branch from 4f38d8e to 34c9af1 Compare September 25, 2024 09:44
Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP CS changes

->setRules([
'@Symfony' => true,
'@Symfony:risky' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

'class_definition' => false,
'concat_space' => ['spacing' => 'one'],
'declare_strict_types' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

Comment on lines 24 to 32
'no_useless_else' => true,
'no_useless_return' => true,
'php_unit_strict' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

'phpdoc_align' => ['align' => 'left'],
'phpdoc_order' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

Comment on lines 32 to 39
'strict_comparison' => true,
'strict_param' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

@Prokyonn Prokyonn force-pushed the enhancement/rename-content-resolver branch from d8116c8 to eaebae2 Compare September 25, 2024 14:55
@Prokyonn Prokyonn enabled auto-merge (squash) September 25, 2024 14:59
@Prokyonn Prokyonn force-pushed the enhancement/rename-content-resolver branch from 4727521 to 828932a Compare September 25, 2024 15:02
@Prokyonn Prokyonn merged commit a23a5b0 into sulu:0.9 Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants