Fix sources in webp source tags of image extension (#46)

sulu · Oct 20, 2022 · 4ed8fda · 4ed8fda
1 parent bda5ea3
commit 4ed8fda
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/ImageExtension.php b/src/ImageExtension.php
@@ -260,6 +260,7 @@ private function createImage(
                 if ($srcset) {
                     $sources[] = [
                         'srcset' => $srcset,
+                        'sizes' => $attributes['sizes'] ?? null,
                         'type' => $type,
                     ];
                 }

diff --git a/tests/Unit/ImageExtensionTest.php b/tests/Unit/ImageExtensionTest.php
@@ -169,6 +169,7 @@ public function testComplexWebpPictureTag(): void
         $this->assertSame(
             '<picture>' .
             '<source srcset="/uploads/media/sulu-100x100/01/image.webp?v=1-0 460w, /uploads/media/sulu-170x170/01/image.webp?v=1-0 800w, /uploads/media/sulu-400x400/01/image.webp?v=1-0 1024w"' .
+            ' sizes="(max-width: 1024px) 100vw, (max-width: 800px) 100vw, 100vw"' .
             ' type="image/webp">' .
             '<img alt="Logo"' .
             ' title="Description"' .