Wrap updates in transaction to avoid one BEGIN/COMMIT per row #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
n
rows processed inm
batches, currently3n
statements are sent to the DB for updates:BEGIN
,UPDATE
,COMMIT
. If the updates were wrapped in a transaction, then it would only sendn + 2m
updates.On a local postgres table with 40000 rows, batch size 1000, anonymizing a single email field.
Before changes: 2m 52s
With transactions: 2m 26s (15% faster)
I'm not sure if this would have undesired effects for others, so maybe this should be configurable?