use activerecord-imports "import"-method #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
+1 |
aiomaster
force-pushed
the
master
branch
5 times, most recently
from
4f823ed to
98a6d67
Compare
|
Hey @sunitparekh, is there anything I can do, to get this stuff in? Thanks! |
|
send pull request
…On Mon, Oct 28, 2019 at 11:11 PM Christoph Wagner ***@***.***> wrote:
Hey @sunitparekh <https://github.com/sunitparekh>,
is there anything I can do, to get this stuff in?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67?email_source=notifications&email_token=AABLNOQX3BUOSML4XDIZK63QQ4P5DA5CNFSM4FK7DMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNYVDY#issuecomment-547064463>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLNOQN2ANRJENOLRE6KMDQQ4P5DANCNFSM4FK7DMOA>
.
--
thanks & regards,
*Sunit Parekh*
+91 99237 00662
[email protected]
|
Hi @sunitparekh, I thought this is a pull request or did I miss something? Thanks |
|
let me rethink about bulk_import.... I need more time to write it with unit tests... meanwhile if you are looking at more performant library of data-anon, please give it a try to https://github.com/dataanon/data-anon (Kotiln/Java version with high performant and batch support) |
aiomaster
referenced
this pull request
Oct 30, 2019
|
Hi there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #66
I know that there are tests missing for the bulk_processing, cause we would need postgresql or mysql in the tests plus the activerecord-import gem (as development_dependency?) and I don't know how a good setup of these things should be done.
I tested the code with my production databases and it works very well.
If
::ActiveRecord::Importis not defined or bulk_processing is explicitly turned off by settingbulk_process falseat the table definition than nothing changes.