perf: preallocate tensor in semantic text generation #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
generate_text_semantic
so that it preallocates a tensor and fills it instead of usingcat
, which results in extra allocations and overhead. It also removes the del line and lets the garbage collector manage things, hopefully async.Overall, on a H100, with some of the other patches, this lets me generate the example prompt:
Slightly faster than realtime. On average, this prompt generates a 12-13s audio clip, and I can generate the clip in around 8-12s. On a good run that's approximately 130% realtime.
I'd note that the performance of the semantic model seems to be especially bimodal - sometimes I get lucky and get > 270it/s, which takes 2s, and other times its slow and does ~150it/s and takes 4s. It'd be nice to eliminate this variance, though I wonder what if it has to do with the model.