Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TableCoordinates support pixel edges and centers #713

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanRyanIrish
Copy link
Member

@DanRyanIrish DanRyanIrish commented May 29, 2024

PR Description

This PR enables support for custom pixel edges in QuantityTableCoordinate and TimeTableCoordinate objects by storing the underlying grids as including pixel edges and centers, not just centers as heretonow.

The motivation is that world coordinates at pixel edges are often wanted. When the pixel widths are uniform, the edges can be found from the centers. However, when this is not the case, explicit knowledge of the edges is required.

@DanRyanIrish DanRyanIrish marked this pull request as draft May 29, 2024 09:16
@DanRyanIrish DanRyanIrish changed the title Make TableCoordinates support custom pixel grids Make TableCoordinates support pixel edges and centers May 30, 2024
@DanRyanIrish
Copy link
Member Author

@Cadair Can you advise on whether this is the best way to go about this?

@DanRyanIrish
Copy link
Member Author

Make TableCoordinate require the input pixel grid to which the input world grid corresponds, and then keep that as the underlying storage. Enable shortcuts for "center" and "corners".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants