Open
Conversation
tomwojcik
requested changes
Nov 5, 2023
Contributor
tomwojcik
left a comment
tomwojcik
left a comment
There was a problem hiding this comment.
Thanks for you contribution! Overall LGTM. I added a test that loads the translations. I think that depending on how you generated the translations, it may or may not be generated with PO-Revision-Date. To my understanding, it should be matching POT-Creation-Date or newer. In this case, matching, probably. Would you be able to fix it?
FAILED testproject/testapp/tests/test_translations.py::test_constants_translations_are_up_to_date - ValueError: time data '' does not match format '%Y-%m-%d %H:%M'
| "Project-Id-Version: djoser\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2020-01-13 17:40+0100\n" | ||
| "PO-Revision-Date: \n" |
Contributor
There was a problem hiding this comment.
Shouldn't it match POT-Creation-Date? Weird that's not been autogenerated with PO-Revision-Date.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a new language (cs) translation.
It is a little unsure if cs_CZ or cs should be used, but czech language is used in Czech Rep. only (except of really ultra small minorities in Romania, Serbia (or maybe Swiss or USA)).
So cs is I think the proper way to go.
And it is compatible with Django and Django Admin - this is probably the 1st point.
Best regards.
Mirek Zvolský