Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Simplify remix example #399

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

dijonmusters
Copy link
Contributor

@dijonmusters dijonmusters commented Dec 7, 2022

What kind of change does this PR introduce?

Simplify Remix example and make it as consistent as possible with Next.js Server Components

What is the current behavior?

Remix example is hard to follow

What is the new behavior?

Remix example covers:

  1. password auth
  2. GitHub OAuth
  3. server-side Supabase client
  4. client-side singleton Supabase instance - shared through outlet context
  5. 100% TypeScript (server and client)
  6. optional session page
  7. required session page
  8. realtime (merging client and server state)
  9. mutations

@dijonmusters dijonmusters force-pushed the chore/update-remix-example branch from e997998 to cfc18db Compare December 7, 2022 05:56
@dijonmusters dijonmusters force-pushed the chore/update-remix-example branch from cfc18db to 2b9f195 Compare December 7, 2022 05:58
Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dijonmusters dijonmusters merged commit 8298d12 into main Dec 7, 2022
@dijonmusters dijonmusters deleted the chore/update-remix-example branch December 7, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants