Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix coverage metering by removing files not under test #1890

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Dec 24, 2024

The -coverpkg option changed in Go 1.20 and now includes files not under test, which skew the actual coverage.

Files not under test:

  • /cmd The commands, these run as part of the executable.
  • /client A non-official admin client that should be removed from the repo in the next major version.
  • /docs Will be removed in a follow up PR.
  • /main.go Main file.

@hf hf requested a review from a team as a code owner December 24, 2024 13:31
@hf hf merged commit 4faea5a into master Dec 24, 2024
3 checks passed
@hf hf deleted the hf/ci-fix-coverage-metering branch December 24, 2024 13:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12482369007

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.3%) to 64.735%

Totals Coverage Status
Change from base Build 12481761512: 7.3%
Covered Lines: 9742
Relevant Lines: 15049

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants