Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve invalid channel error message returned #1908

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Improve error message around invalid channel error for phone auth. Only twilio and twilio verify support whatsapp as a valid channel.

@kangmingtay kangmingtay requested a review from a team as a code owner January 10, 2025 19:22
@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12755234219

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.435%

Totals Coverage Status
Change from base Build 12707782762: 0.0%
Covered Lines: 9814
Relevant Lines: 14998

💛 - Coveralls

internal/api/errors.go Outdated Show resolved Hide resolved
Co-authored-by: Stojan Dimitrovski <[email protected]>
@kangmingtay kangmingtay enabled auto-merge (squash) January 13, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants