Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements to config reloader, 100% coverage #1933

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

cstockton
Copy link
Contributor

Increased test coverage of reloader to 100%.

@cstockton cstockton requested a review from a team as a code owner February 3, 2025 17:43
@hf hf changed the title chore: 100% test coverage and minor improvements to reloader feat: improvements to config reloader, 100% coverage Feb 3, 2025
@coveralls
Copy link

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build 13122438877

Details

  • 68 of 69 (98.55%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 66.158%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reloader/reloader.go 68 69 98.55%
Totals Coverage Status
Change from base Build 13061050652: 0.6%
Covered Lines: 9980
Relevant Lines: 15085

💛 - Coveralls

Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I changed the title of the PR, anything that includes code changes should pretty much always be feat or fix.

@cstockton cstockton merged commit 21c2256 into master Feb 4, 2025
5 checks passed
@cstockton cstockton deleted the cs/reload-coverage branch February 4, 2025 17:55
kangmingtay pushed a commit that referenced this pull request Mar 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.170.0](v2.169.0...v2.170.0)
(2025-03-06)


### Features

* improvements to config reloader, 100% coverage
([#1933](#1933))
([21c2256](21c2256))
* increase test coverage in conf package to 100%
([#1937](#1937))
([bc57c1c](bc57c1c))


### Bug Fixes

* enable SO_REUSEPORT in listener config
([#1936](#1936))
([a474b80](a474b80))
* ignore not found error to check for pkce prefix later
([#1929](#1929))
([fbbebcc](fbbebcc))
* log version & migration count
([#1934](#1934))
([8078cdc](8078cdc))
* update figma token endpoint
([#1952](#1952))
([18fbbb5](18fbbb5))
* use sys/unix instead of syscall
([#1953](#1953))
([4a6d9bc](4a6d9bc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants