Add Custom Config File Support #3092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/custom config flag
Pull Request Test Coverage Report for Build 13083225214Details
💛 - Coveralls |
sweatybridge
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Generally agree to add this functionality. However, the current implementation doesn't handle changing workdir based on the given config path.
Adds support for setting the working directory based on the provided config file path: - Handles both absolute and relative config paths - Normalizes paths across platforms - Maintains Windows compatibility by handling drive letters - Preserves existing behavior when no config file is specified This addresses the feedback about workdir handling in the CLI by ensuring the working directory is properly set based on the config file location. Tests added: - Relative config paths - Absolute config paths - Non-existent config paths - Malformed config files
feat(cli): handle workdir based on config file path
Thanks for the feedback! I think I have addressed the issues with my latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Custom Config File Support
Introduces a new
--config-fileflag to the Supabase CLI, enabling users to specify alternative configuration files. This enhancement allows running multiple parallel local development environments with different configurations (#2139).Example Usage
Benefits