feat: update envoy lds with origin protection keys #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should go out to all Postgres versions that can be selected by customers. How do I do that? |
pcnc
reviewed
Jan 9, 2025
Comment on lines
+98
to
+99
| or_ids: | ||
| ids: |
There was a problem hiding this comment.
Any reason for not doing a direct comparison here rather than an array check?
There was a problem hiding this comment.
There can be multiple keys here, coming from the trusted_keys column, to enable easy rotation.
pcnc
approved these changes
Jan 9, 2025
hf
force-pushed
the
hf/update-supabase-envoy-lds-with-opk
branch
from
f76e053 to
679fecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
lds.supabase.yamlfile to include origin protection keys by default. The stringsupabase_origin_protection_keyis replaced with the exact OPK during project initialization.See also: