fix: drop pg_cron event trigger #785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like migrations are deployed on prod upon merging to develop. That means we can't merge this PR now, because restored projects won't have the after-create.sql until the new AMI is out on prod. We can remove the event trigger in a new AMI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have an after-create script in https://github.com/supabase/postgres/blob/13b317b3bc74e4b2da7c1860b6f43e432fb17c8d/ansible/files/postgresql_extension_custom_scripts/pg_cron/after-create.sql , so the event trigger is redundant.
Why move away from event triggers: https://www.notion.so/supabase/move-away-from-event-triggers-to-custom-extension-scripts-08cb6c4fae39422ba57fd11135d71659?pvs=4
15.1.0.132 hasn't been deployed so seems fine to edit the migration in place, if not I'll write the change as a new migration