Merge pull request #155 from supabase/fix/quoting

fix: remove quoting of names
supabase · Feb 14, 2021 · 9ecb985 · 9ecb985
2 parents eacc4f7 + fb0b82c
commit 9ecb985
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/lib/PostgrestFilterBuilder.ts b/src/lib/PostgrestFilterBuilder.ts
@@ -4,7 +4,7 @@ import PostgrestTransformBuilder from './PostgrestTransformBuilder'
  * Filters
  */
 
-const cleanFilterArray = <T>(filter: T[keyof T][]) => filter.map((s) => `"${s}"`).join(',')
+const cleanFilterArray = <T>(filter: T[keyof T][]) => filter.map((s) => `${s}`).join(',')
 
 type FilterOperator =
   | 'eq'

diff --git a/src/lib/PostgrestTransformBuilder.ts b/src/lib/PostgrestTransformBuilder.ts
@@ -45,7 +45,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
       foreignTable,
     }: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}
   ): this {
-    const key = typeof foreignTable === 'undefined' ? 'order' : `"${foreignTable}".order`
+    const key = typeof foreignTable === 'undefined' ? 'order' : `${foreignTable}.order`
     this.url.searchParams.set(
       key,
       `${column}.${ascending ? 'asc' : 'desc'}.${nullsFirst ? 'nullsfirst' : 'nullslast'}`
@@ -60,7 +60,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
    * @param foreignTable  The foreign table to use (for foreign columns).
    */
   limit(count: number, { foreignTable }: { foreignTable?: string } = {}): this {
-    const key = typeof foreignTable === 'undefined' ? 'limit' : `"${foreignTable}".limit`
+    const key = typeof foreignTable === 'undefined' ? 'limit' : `${foreignTable}.limit`
     this.url.searchParams.set(key, `${count}`)
     return this
   }
@@ -73,8 +73,8 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
    * @param foreignTable  The foreign table to use (for foreign columns).
    */
   range(from: number, to: number, { foreignTable }: { foreignTable?: string } = {}): this {
-    const keyOffset = typeof foreignTable === 'undefined' ? 'offset' : `"${foreignTable}".offset`
-    const keyLimit = typeof foreignTable === 'undefined' ? 'limit' : `"${foreignTable}".limit`
+    const keyOffset = typeof foreignTable === 'undefined' ? 'offset' : `${foreignTable}.offset`
+    const keyLimit = typeof foreignTable === 'undefined' ? 'limit' : `${foreignTable}.limit`
     this.url.searchParams.set(keyOffset, `${from}`)
     // Range is inclusive, so add 1
     this.url.searchParams.set(keyLimit, `${to - from + 1}`)