feat: check for private key on public Channel and error #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
approved these changes
Aug 8, 2024
|
Inspector is now compatible with private Channels and messages. |
filipecabaco
approved these changes
Aug 23, 2024
filipecabaco
force-pushed
the
feat/require-private-key-private-channel
branch
from
bfa8e6e to
47953d1
Compare
filipecabaco
force-pushed
the
feat/require-private-key-private-channel
branch
from
47953d1 to
af73a79
Compare
|
rebased the PR against main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer, if I want to ensure my private messages are sent on a private Channel I can include a
privatekey with valuetrue.If a message with a
privatekey of valuetrueis sent on a public Channel, the Realtime server will error and close the socket.