fix: Disconnect when tenant has no users #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
1 similar comment
chasers
reviewed
Oct 17, 2023
chasers
reviewed
Oct 17, 2023
filipecabaco
force-pushed
the
fix/disconnect-from-tenant-on-no-users
branch
from
20af583 to
56393c4
Compare
abc3
reviewed
Oct 19, 2023
abc3
reviewed
Oct 19, 2023
filipecabaco
force-pushed
the
fix/disconnect-from-tenant-on-no-users
branch
from
c008137 to
c0e5045
Compare
chasers
reviewed
Oct 20, 2023
|
|
||
| def handle_info(:shutdown, %{db_conn_pid: db_conn_pid} = state) do | ||
| Logger.info("Tenant has no connected users, database connection will be terminated") | ||
| :ok = GenServer.stop(db_conn_pid) |
There was a problem hiding this comment.
What happens after this? Is the process going to keep checking and trying to kill a db_conn_pid that doesn't exist?
There was a problem hiding this comment.
Since we're monitoring the reference of this connection it will be caught by the handle info for that effect and kill itself
chasers
approved these changes
Oct 20, 2023
chasers
reviewed
Oct 20, 2023
chasers
reviewed
Oct 20, 2023
chasers
reviewed
Oct 20, 2023
|
@filipecabaco take the nits if you want and feel free to merge whenever. |
filipecabaco
force-pushed
the
fix/disconnect-from-tenant-on-no-users
branch
from
776dcd3 to
cff7818
Compare
To ensure that we limit the amount of connections to a tenant database, we will check if that tenant has any users and if not, we kill the database connection.
filipecabaco
force-pushed
the
fix/disconnect-from-tenant-on-no-users
branch
from
cff7818 to
6991704
Compare
|
🎉 This PR is included in version 2.25.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
To ensure that we limit the amount of connections to a tenant database, we will check if that tenant has any users and if not, we kill the database connection.