Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Channels listing endpoint #732

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

Adds the listing endpoints and implements more changes to the way we're loading data

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:08pm

@filipecabaco filipecabaco requested review from w3b6x9, chasers and abc3 and removed request for w3b6x9 and chasers November 9, 2023 17:46
@filipecabaco filipecabaco force-pushed the fix/list-channels-controller branch from 1a6dff2 to fc10197 Compare November 9, 2023 18:18
@filipecabaco filipecabaco requested a review from chasers November 9, 2023 18:24
@filipecabaco filipecabaco force-pushed the fix/list-channels-controller branch from fc10197 to fe4f578 Compare November 9, 2023 19:12
lib/realtime/channels.ex Outdated Show resolved Hide resolved
lib/realtime/channels.ex Outdated Show resolved Hide resolved
lib/realtime/channels.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@abc3 abc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge it when it's ready

@filipecabaco filipecabaco requested a review from a team November 15, 2023 17:32
lib/realtime/repo.ex Outdated Show resolved Hide resolved
lib/realtime/channels.ex Outdated Show resolved Hide resolved
Copy link

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have only added some minor nits!

@filipecabaco filipecabaco force-pushed the fix/list-channels-controller branch 2 times, most recently from e8fd8cd to 361a269 Compare November 15, 2023 22:02
Adds the listing endpoints and implements more changes to the way we're loading data
@filipecabaco filipecabaco force-pushed the fix/list-channels-controller branch from 361a269 to f9f23eb Compare November 15, 2023 22:08
@filipecabaco filipecabaco merged commit 9d81e04 into main Nov 15, 2023
3 checks passed
@filipecabaco filipecabaco deleted the fix/list-channels-controller branch November 15, 2023 22:38
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.25.31 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants