Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add delete endpoint #744

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix: Add delete endpoint #744

merged 2 commits into from
Nov 20, 2023

Conversation

filipecabaco
Copy link
Member

@filipecabaco filipecabaco commented Nov 18, 2023

What kind of change does this PR introduce?

Adds delete endpoint along with other delete code required for the feature

To be merged after #743

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 1:02pm

@filipecabaco filipecabaco requested review from abc3, chasers and a team November 18, 2023 02:10
Copy link
Contributor

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment around error handling.

lib/realtime/repo.ex Outdated Show resolved Hide resolved
lib/realtime/repo.ex Outdated Show resolved Hide resolved
lib/realtime/repo.ex Outdated Show resolved Hide resolved
@filipecabaco filipecabaco force-pushed the fix/delete-channel-endpoint branch from d7fc050 to ed6550f Compare November 20, 2023 12:51
@filipecabaco filipecabaco force-pushed the fix/create-channel-controller branch from cb0856b to eda2533 Compare November 20, 2023 12:53
Base automatically changed from fix/create-channel-controller to main November 20, 2023 12:58
Adds delete endpoint along with other delete code required for the feature
@filipecabaco filipecabaco force-pushed the fix/delete-channel-endpoint branch from ed6550f to 1c158e3 Compare November 20, 2023 13:02
@filipecabaco filipecabaco merged commit 22e277d into main Nov 20, 2023
3 checks passed
@filipecabaco filipecabaco deleted the fix/delete-channel-endpoint branch November 20, 2023 13:48
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.25.38 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants