fix: Fetch S3 credentials for S3 upload of crash dumps #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Using the details given by https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html we will fetch key and secret given the container IAM roles
filipecabaco
force-pushed
the
fix/fetch-s3-credentials-from-relative-uri
branch
from
8556d77 to
09a9e04
Compare
abc3
reviewed
Nov 20, 2023
@delgado3d made the change to add a sub path will also remove minio from development since we've proven it works (in another PR after we have S3 properly proven working) |
|
🎉 This PR is included in version 2.25.39 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Using the details given by https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html we will fetch key and secret given the container IAM roles