Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Update endpoint and required Repo changes #749

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

Add Update endpoint and required Repo changes

@filipecabaco filipecabaco requested review from chasers, abc3, w3b6x9 and a team November 22, 2023 00:22
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 4:11pm

@filipecabaco filipecabaco force-pushed the fix/update-channel-endpoint branch from b18ae23 to 02bed00 Compare November 22, 2023 00:23
Copy link

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Only two minor suggestions :)

lib/realtime/repo.ex Outdated Show resolved Hide resolved
test/realtime/repo_test.exs Outdated Show resolved Hide resolved
@filipecabaco filipecabaco force-pushed the fix/update-channel-endpoint branch from 7f47658 to df893ad Compare November 22, 2023 16:07
@filipecabaco filipecabaco merged commit 29d2257 into main Nov 22, 2023
3 checks passed
@filipecabaco filipecabaco deleted the fix/update-channel-endpoint branch November 22, 2023 16:18
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.25.40 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants