Skip to content

fix(auth): pass alg to importJWK for jose v6 compatibility with Auth0… #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameron-michie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(auth): pass alg to importJWK for jose v6 compatibility with Auth0… #1097

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f46fa2f
fix(auth): pass alg to importJWK for jose v6 compatibility with Auth0…
cameron-michie May 11, 2026
3dae83d
fix(auth): reject JWKs whose alg field conflicts with JWT header alg
cameron-michie May 12, 2026
ca1c0d8
test(auth): add coverage for asymmetric JWKs without alg and alg mism…
cameron-michie May 12, 2026
222e073
chore: fix lint formatting in jwt.test.ts
cameron-michie May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/internal/auth/jwt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ async function findJWKFromHeader(
// couldn't find a matching JWK, try to use the secret
return encoder.encode(secret)
}
return await importJWK(jwk)
return await importJWK(jwk, header.alg)

@ferhatelmas ferhatelmas May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we also need to fix the jwk filtering above because otherwise jwk with a particular algorithm will verify a token with an algorithm that isn't created for. For example, jwk says RS256 but header says RS512

And it's also better to pass jwk.alg || header.alg here for clearer intention

}
Comment on lines 98 to 102

@ferhatelmas ferhatelmas May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we need to see some tests as well

@ferhatelmas ferhatelmas May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • accept asymmetric jwt when matching jwk has no alg
  • reject asymmetric jwt when matching jwk has a different alg
  • reject hmac jwt when matching jwk has a different alg


function getJWTVerificationKey(secret: string, jwks: JwksConfig | null): JWTVerifyGetKey {
Expand Down