Skip to content

Conversation

itslenny
Copy link
Contributor

What kind of change does this PR introduce?

Feature

What is the current behavior?

Custom response headers are not supported for GetObject commands

What is the new behavior?

Adds support for GetObject() custom response headers in S3 protocol including:

  • response-content-disposition
  • response-content-type
  • response-cache-control
  • response-content-encoding
  • response-content-language
  • response-expires

Also, resolved all eslint warnings in s3-handler.ts

Additional context

Closes #544 – Content-Disposition for GetObject() not working

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html

@coveralls
Copy link

coveralls commented Oct 15, 2025

Pull Request Test Coverage Report for Build 18568013015

Details

  • 67 of 76 (88.16%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 76.389%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/s3/commands/get-object.ts 27 36 75.0%
Totals Coverage Status
Change from base Build 18352064985: 0.02%
Covered Lines: 21224
Relevant Lines: 27553

💛 - Coveralls

@itslenny itslenny requested a review from fenos October 15, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 Compatibility: Content-Disposition for GetObject() not working

2 participants