Skip to content

fix(realtime): use 'event' instead of 'events' in postgres_changes protocol #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexwhitmore wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix(realtime): use 'event' instead of 'events' in postgres_changes protocol #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/realtime/src/realtime/_async/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def on_join_push_ok(payload: ReplyPostgresChanges):

if (
server_binding
and server_binding.events == postgres_callback.event
and server_binding.event == postgres_callback.event
and server_binding.schema_ == postgres_callback.schema
and server_binding.table == postgres_callback.table
and server_binding.filter == postgres_callback.filter
Expand Down
4 changes: 2 additions & 2 deletions src/realtime/src/realtime/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class JoinMessage(BaseModel):

class PostgresRowChange(BaseModel):
id: int
events: RealtimePostgresChangesListenEvent
table: str
event: RealtimePostgresChangesListenEvent
table: Optional[str] = None
schema_: Optional[str] = Field(alias="schema", default=None)
filter: Optional[str] = None

Expand Down
4 changes: 3 additions & 1 deletion src/realtime/src/realtime/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,11 @@ def __call__(self, payload: PostgresChangesPayload) -> None:

@property
def binding_filter(self) -> dict[str, Optional[str]]:
binding = {"events": self.event, "table": self.table}
binding = {"event": self.event}
if self.schema:
binding["schema"] = self.schema
if self.table:
binding["table"] = self.table
if self.filter:
binding["filter"] = self.filter
return binding
Expand Down