Fixes #292 #293
Closed
Fixes #292 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leoMehlig for the PR, I made a few changes to it, going to push it. |
|
Closing in favor of #294, thanks @leoMehlig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes the bug described in #292.
StoredSessionTests, which includes tests to decode the previous JSON and the current.identityIdto make it backwards-compatible with theStoredSessionin 2.4.0What is the current behavior?
Decoding an old stored session would fail.
What is the new behavior?
Decoding an old stored session uses a default (all zeros) value for
identityIdAdditional context
An alternative approach would be to make
identityIdoptional, but that requires changes elsewhere in the SDK. The upside of that approach is, that it is more explicit and would not require custom Codable code.