Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(auth): add tests for auto verifying stored session compatibility #295

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Apr 1, 2024

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@grdsdev grdsdev enabled auto-merge (squash) April 1, 2024 13:41
@grdsdev grdsdev merged commit b3ac087 into main Apr 1, 2024
3 of 6 checks passed
@grdsdev grdsdev deleted the test/auth/stored-session-compatiblity branch April 1, 2024 13:54
@leoMehlig
Copy link
Contributor

Quick question: How is the test now verifying the backwards comp to 2.4.0? The JSON file represents the 2.5.0 schema, right?

@grdsdev
Copy link
Collaborator Author

grdsdev commented Apr 3, 2024

Hey, it doesn't verify specifically the 2.4.0 compatibility, but now it stores values in a JSON file, so the test verifies it can load the previous stored value (asserting that it is compatible with older versions), and then update the stored value.

If we make incompatible change to StoredSession type, it will fail to decode from the current local-storage.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants