Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed model cleanup on cluster #2683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed model cleanup on cluster #2683

wants to merge 1 commit into from
+33 −7

Conversation

kartik4949
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

jieguangzhou
jieguangzhou requested changes Dec 30, 2024
View reviewed changes
superduper/templates/__init__.py
Comment on lines +33 to +34
breakpoint()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

superduper/components/model.py
:param db: Data layer instance to process.
"""
db.cluster.compute.drop_component(self.uuid)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call db.cluster.drop_component and all other related logic should be handled within db.cluster.drop_component.

Otherwise, we will sometimes call cluster.drop_component in some places, and at other times, we will call cluster.compute.drop_component.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieguangzhou jieguangzhou jieguangzhou requested changes

@blythed blythed blythed approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartik4949 @blythed @jieguangzhou